-
Couldn't load subscription status.
- Fork 11
Chore bump paperclip to 0.9.1 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Thanks for this contribution!
I cannot merge as is, because there are a few imperfections.
Is it OK with you if I do the update myself and release a new version?
This would be faster for you and for me...
| [[example]] | ||
| name = "custom_claims" | ||
| path = "examples/custom_claims.rs" | ||
| required-features = ["paperclip_compat"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required because the paperclip_compat is not needed for this example
| [[example]] | ||
| name = "simple" | ||
| path = "examples/simple.rs" | ||
| required-features = ["paperclip_compat"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required because the paperclip_compat is not needed for this example
| uuid = { version = "1.6.1", features = ["serde"] } | ||
| paperclip = { version = "0.8.2", default-features = false, features = ["actix4"], optional = true } | ||
| uuid = { version = "1.10.0", features = ["serde"] } | ||
| paperclip = { version = "0.9.1", default-features = false, features = ["actix4", "paperclip-actix"], optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you do not need to explicitly add the paperclip-actix feature as it is enabled by the actix4 one
| [[example]] | ||
| name = "paperclip" | ||
| path = "examples/paperclip.rs" | ||
| required-features = ["paperclip_compat"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool but we should update examples/README.md accordingly
Sure. Please go ahead. Thank you very much. |
|
Thanks again for your help! I just published |
Update Dependencies
This PR updates several dependencies to their latest versions.
Background
actix-web-middleware-keycloak-auth does not work with paperclip 0.9.1.
Changes
Dependency Updates
actix-webfrom 4.4.0 to 4.9.0chronofrom 0.4.31 to 0.4.38futures-utilfrom 0.3.29 to 0.3.30logfrom 0.4.20 to 0.4.22jsonwebtokenfrom 9.2.0 to 9.3.0serdefrom 1.0.193 to 1.0.210uuidfrom 1.6.1 to 1.10.0paperclipfrom 0.8.2 to 0.9.1env_logger(dev dependency) from 0.10.1 to 0.11.5Paperclip Configuration
Updated the
paperclipdependency configuration to include thepaperclip-actixfeature.