Skip to content

Conversation

@thomedw
Copy link

@thomedw thomedw commented Sep 28, 2024

Update Dependencies

This PR updates several dependencies to their latest versions.

Background

actix-web-middleware-keycloak-auth does not work with paperclip 0.9.1.

Changes

Dependency Updates

  • Upgraded actix-web from 4.4.0 to 4.9.0
  • Upgraded chrono from 0.4.31 to 0.4.38
  • Upgraded futures-util from 0.3.29 to 0.3.30
  • Upgraded log from 0.4.20 to 0.4.22
  • Upgraded jsonwebtoken from 9.2.0 to 9.3.0
  • Upgraded serde from 1.0.193 to 1.0.210
  • Upgraded uuid from 1.6.1 to 1.10.0
  • Upgraded paperclip from 0.8.2 to 0.9.1
  • Upgraded env_logger (dev dependency) from 0.10.1 to 0.11.5

Paperclip Configuration

Updated the paperclip dependency configuration to include the paperclip-actix feature.

Copy link
Owner

@dsferruzza dsferruzza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Thanks for this contribution!
I cannot merge as is, because there are a few imperfections.

Is it OK with you if I do the update myself and release a new version?
This would be faster for you and for me...

Comment on lines +14 to +17
[[example]]
name = "custom_claims"
path = "examples/custom_claims.rs"
required-features = ["paperclip_compat"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required because the paperclip_compat is not needed for this example

Comment on lines +24 to +27
[[example]]
name = "simple"
path = "examples/simple.rs"
required-features = ["paperclip_compat"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required because the paperclip_compat is not needed for this example

uuid = { version = "1.6.1", features = ["serde"] }
paperclip = { version = "0.8.2", default-features = false, features = ["actix4"], optional = true }
uuid = { version = "1.10.0", features = ["serde"] }
paperclip = { version = "0.9.1", default-features = false, features = ["actix4", "paperclip-actix"], optional = true }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you do not need to explicitly add the paperclip-actix feature as it is enabled by the actix4 one

[[example]]
name = "paperclip"
path = "examples/paperclip.rs"
required-features = ["paperclip_compat"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool but we should update examples/README.md accordingly

@thomedw
Copy link
Author

thomedw commented Sep 29, 2024

Hi! Thanks for this contribution! I cannot merge as is, because there are a few imperfections.

Is it OK with you if I do the update myself and release a new version? This would be faster for you and for me...

Sure. Please go ahead. Thank you very much.

@dsferruzza
Copy link
Owner

Thanks again for your help! I just published v0.5.0 🙂

@dsferruzza dsferruzza closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants