Small adjustment in order to make yarn-completion.bash compatible to zsh #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsifford
reviewed
Dec 20, 2023
| " RETURN | ||
|
|
||
| shopt -s extglob | ||
| if [[ "$SHELL" != "/bin/zsh" && "$SHELL" != "/usr/bin/zsh" ]]; then |
There was a problem hiding this comment.
What if zsh is installed in a non-standard path? Like if installed by homebrew or something? Is there a more reliable way of determining this?
Or perhaps instead of making this a check of the negative ("this shell is not zsh"), maybe it would be better to make this a check of the affirmative ("this shell is bash").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for me on zsh 5.8.1 (x86_64-ubuntu-linux-gnu) when adding the following to ~/.zshrc:
source yarn-completion.bash