fix: make cluster_identifier optional for use with global clusters

dstrates · dstrates · commit e64143a46e9e · 2025-01-06T14:53:44.000+11:00
diff --git a/README.md b/README.md
@@ -24,7 +24,7 @@ Neptune serverless requires that the `engine_version` attribute must be `1.2.0.1
 
 module "neptune" {
   source  = "dstrates/neptune/aws"
-  version = "0.1.2"
+  version = "0.1.3"
 
   apply_immediately                      = true
   backup_retention_period                = 5
@@ -77,7 +77,7 @@ module "neptune" {
 ```hcl
 module "neptune" {
   source  = "dstrates/neptune/aws"
-  version = "0.1.2"
+  version = "0.1.3"
 
   # Standard configuration
   # ...
@@ -166,7 +166,7 @@ No modules.
 | <a name="input_apply_immediately"></a> [apply\_immediately](#input\_apply\_immediately)                                                                                       | Specifies whether cluster modifications are applied immediately                                                                                                                                                                         | `bool`                                                                                                                                                                                     | `true`                                                                                                           |    no    |
 | <a name="input_availability_zones"></a> [availability\_zones](#input\_availability\_zones)                                                                                    | (Optional) A list of EC2 Availability Zones that instances in the Neptune cluster can be created in.                                                                                                                                    | `list(string)`                                                                                                                                                                             | `null`                                                                                                           |    no    |
 | <a name="input_backup_retention_period"></a> [backup\_retention\_period](#input\_backup\_retention\_period)                                                                   | The number of days to retain backups for                                                                                                                                                                                                | `number`                                                                                                                                                                                   | `7`                                                                                                              |    no    |
-| <a name="input_cluster_identifier"></a> [cluster\_identifier](#input\_cluster\_identifier)                                                                                    | The cluster identifier                                                                                                                                                                                                                  | `string`                                                                                                                                                                                   | n/a                                                                                                              |   yes    |
+| <a name="input_cluster_identifier"></a> [cluster\_identifier](#input\_cluster\_identifier)                                                                                    | The cluster identifier. Required if create\_neptune\_cluster is true.                                                                                                                                                                   | `string`                                                                                                                                                                                   | `null`                                                                                                           |    no    |
 | <a name="input_cluster_identifier_prefix"></a> [cluster\_identifier\_prefix](#input\_cluster\_identifier\_prefix)                                                             | (Optional) Creates a unique cluster identifier beginning with the specified prefix. Conflicts with cluster\_identifier.                                                                                                                 | `string`                                                                                                                                                                                   | `null`                                                                                                           |    no    |
 | <a name="input_copy_tags_to_snapshot"></a> [copy\_tags\_to\_snapshot](#input\_copy\_tags\_to\_snapshot)                                                                       | (Optional) If set to true, tags are copied to any snapshot of the DB cluster that is created.                                                                                                                                           | `bool`                                                                                                                                                                                     | `null`                                                                                                           |    no    |
 | <a name="input_create_neptune_cluster"></a> [create\_neptune\_cluster](#input\_create\_neptune\_cluster)                                                                      | Whether or not to create a Neptune cluster                                                                                                                                                                                              | `bool`                                                                                                                                                                                     | `true`                                                                                                           |    no    |
diff --git a/examples/global-cluster-existing/main.tf b/examples/global-cluster-existing/main.tf
@@ -53,7 +53,7 @@ data "aws_kms_key" "default" {
 # Assuming you have an existing standard Neptune cluster
 module "neptune_existing_cluster" {
   source  = "dstrates/neptune/aws"
-  version = "0.1.2"
+  version = "0.1.3"
 
   create_neptune_cluster                 = true
   create_neptune_subnet_group            = true
@@ -95,7 +95,7 @@ module "neptune_existing_cluster" {
 # Create a global cluster referencing that cluster
 module "neptune_global_cluster" {
   source  = "dstrates/neptune/aws"
-  version = "0.1.2"
+  version = "0.1.3"
 
   create_neptune_global_cluster               = true
   global_cluster_engine                       = "neptune"
diff --git a/examples/read-replica/main.tf b/examples/read-replica/main.tf
@@ -96,7 +96,7 @@ data "aws_kms_key" "secondary" {
 
 module "neptune_primary" {
   source  = "dstrates/neptune/aws"
-  version = "0.1.2"
+  version = "0.1.3"
 
   providers = {
     aws = aws.primary
@@ -145,7 +145,7 @@ module "neptune_primary" {
 
 module "neptune_replica" {
   source  = "dstrates/neptune/aws"
-  version = "0.1.2"
+  version = "0.1.3"
 
   providers = {
     aws = aws.secondary
diff --git a/variables.tf b/variables.tf
@@ -23,8 +23,9 @@ variable "backup_retention_period" {
 }
 
 variable "cluster_identifier" {
-  description = "The cluster identifier"
+  description = "The cluster identifier. Required if create_neptune_cluster is true."
   type        = string
+  default     = null
 }
 
 variable "cluster_identifier_prefix" {

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,9 @@ variable "backup_retention_period" {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`variable "cluster_identifier" {`
`26`		`- description = "The cluster identifier"`
	`26`	`+ description = "The cluster identifier. Required if create_neptune_cluster is true."`
`27`	`27`	`type = string`
	`28`	`+ default = null`
`28`	`29`	`}`
`29`	`30`
`30`	`31`	`variable "cluster_identifier_prefix" {`