Skip to content

Commit 74be8ee

Browse files
authored
Remove setSession from VPNService (#6143)
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210381575256073?focus=true ### Description Remove setSession temporarily as we are not sure if it could negatively effect VPN on other OEMs ### Steps to test this PR Qa-optional
1 parent 7a8d1a5 commit 74be8ee

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

app-tracking-protection/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/service/TrackerBlockingVpnService.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ import logcat.LogPriority.WARN
8585
import logcat.asLog
8686
import logcat.logcat
8787

88-
private const val DDG_VPN_SESSION = "DuckDuckGo"
89-
9088
@InjectWith(
9189
scope = VpnScope::class,
9290
delayGeneration = true,
@@ -449,7 +447,6 @@ class TrackerBlockingVpnService : VpnService(), CoroutineScope by MainScope(), V
449447
// TODO should we protect all comms with our controller BE? other VPNs do that
450448
safelyAddDisallowedApps(listOf(this@TrackerBlockingVpnService.packageName))
451449
setBlocking(true)
452-
setSession(DDG_VPN_SESSION)
453450
setMtu(1280)
454451
try {
455452
prepare(this@TrackerBlockingVpnService)
@@ -530,9 +527,6 @@ class TrackerBlockingVpnService : VpnService(), CoroutineScope by MainScope(), V
530527
}
531528

532529
setBlocking(true)
533-
// optional in docs but apparently some OEMs may expect to have a session
534-
setSession(DDG_VPN_SESSION)
535-
536530
// Cap the max MTU value to avoid backpressure issues in the socket
537531
// This is effectively capping the max segment size too
538532
setMtu(tunnelConfig.mtu)

0 commit comments

Comments
 (0)