Skip to content

Remove setSession from VPNService #6143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Remove setSession from VPNService #6143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...impl/src/main/java/com/duckduckgo/mobile/android/vpn/service/TrackerBlockingVpnService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ import logcat.LogPriority.WARN
import logcat.asLog
import logcat.logcat

private const val DDG_VPN_SESSION = "DuckDuckGo"

@InjectWith(
scope = VpnScope::class,
delayGeneration = true,
Expand Down Expand Up @@ -449,7 +447,6 @@ class TrackerBlockingVpnService : VpnService(), CoroutineScope by MainScope(), V
// TODO should we protect all comms with our controller BE? other VPNs do that
safelyAddDisallowedApps(listOf(this@TrackerBlockingVpnService.packageName))
setBlocking(true)
setSession(DDG_VPN_SESSION)
setMtu(1280)
try {
prepare(this@TrackerBlockingVpnService)
Expand Down Expand Up @@ -530,9 +527,6 @@ class TrackerBlockingVpnService : VpnService(), CoroutineScope by MainScope(), V
}

setBlocking(true)
// optional in docs but apparently some OEMs may expect to have a session
setSession(DDG_VPN_SESSION)

// Cap the max MTU value to avoid backpressure issues in the socket
// This is effectively capping the max segment size too
setMtu(tunnelConfig.mtu)
Expand Down
Loading