-
Notifications
You must be signed in to change notification settings - Fork 986
Sense of Protection Experiemnt: Add new experiment names #6145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sense of Protection Experiemnt: Add new experiment names #6145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Sense of Protection experiment toggles by renaming the existing toggle methods and updating all related tests to use the new names. Key changes include:
- Adding new toggle names “senseOfProtectionNewUserExperiment27May25” and “senseOfProtectionExistingUserExperiment27May25” in the visual design experiment data store.
- Updating tests across several modules to reference the new toggle methods.
- Adjusting API calls in the SenseOfProtection experiment implementations and related view models.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
common/common-ui/src/main/java/com/duckduckgo/common/ui/experiments/visual/store/VisualDesignExperimentDataStoreImpl.kt | Added new experiment toggle names alongside legacy entries |
app/src/test/java/com/duckduckgo/app/tabs/ui/TabSwitcherViewModelTest.kt | Updated experiment toggle references in tests |
app/src/test/java/com/duckduckgo/app/survey/rmf/TemporaryDefaultSurveyParametersPluginTest.kt | Updated toggle references for survey parameter plugin tests |
app/src/test/java/com/duckduckgo/app/browser/senseofprotection/SenseOfProtectionExperimentImplTest.kt | Updated toggle method calls and assertions in experiment tests |
app/src/main/java/com/duckduckgo/app/survey/rmf/TemporaryDefaultSurveyParameters.kt | Updated toggle method reference for survey parameters evaluation |
app/src/main/java/com/duckduckgo/app/browser/senseofprotection/SenseOfProtectionExperimentToggles.kt | Renamed toggle method declarations |
app/src/main/java/com/duckduckgo/app/browser/senseofprotection/SenseOfProtectionExperimentImpl.kt | Updated toggle method calls in experiment enrollment and parameter extraction |
app/src/internal/java/experiments/trackersblocking/TrackersBlockingExperimentViewModel.kt | Updated toggle method calls in the trackers blocking experiment view model |
Comments suppressed due to low confidence (1)
common/common-ui/src/main/java/com/duckduckgo/common/ui/experiments/visual/store/VisualDesignExperimentDataStoreImpl.kt:56
- Consider removing the legacy toggle names if they are no longer used to avoid potential confusion between the old and new experiment names.
"senseOfProtectionNewUserExperimentMay25",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikescamell could you also add a unit test for the new experiment name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukasPaczos tests added here cd3fc4b
(#6145)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1210385405168427
Description
Updated the Sense of Protection experiment toggle names from
senseOfProtectionNewUserExperimentMay25
andsenseOfProtectionExistingUserExperimentMay25
tosenseOfProtectionNewUserExperiment27May25
andsenseOfProtectionExistingUserExperiment27May25
respectively. Also added these new toggle names to the list of visual design experiment toggles.Steps to test this PR
Sense of Protection Experiment
UI changes
N/A