Update non-critical Autofill tests so they can run against internal builds again #6146
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LukasPaczos
approved these changes
May 27, 2025
CDRussell
deleted the
feature/craig/fix_autofill_tests_can_run_on_internal_again
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210387502072421?focus=true
Description
Updates the remaining Autofill tests to run against
internalbuild types. The critical tests were updated already.Steps to test this PR
This is QA optional. If you want to test:
./gradlew autofillTestLocalcorrectly installs a build which forces default variant and has auth requirement disabled, and that it runs the following test types:autofillNoAuthTests,autofillPasswordGeneration,autofillBackfillingUsername. (note, typically tested against API 30/33, other APIs might not succeed due to minor unaccounted for differences)