Skip to content

Renamed cohorts for experiment reactivateUsersExperimentMay25. #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented May 27, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/task/1210391900429638?focus=true

Description

Updated cohort names in ReactivateUsersToggles.kt to use camelCase format:

  • Changed duckplayer_prompt to duckplayerPrompt
  • Changed browser_prompt to browserPrompt

Steps to test this PR

Cohort naming

  • Verify that the cohort names are correctly updated in the codebase
  • Ensure that any existing references to these cohorts are updated or handle both naming formats

NO UI changes


Copy link
Contributor Author

anikiki commented May 27, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anikiki anikiki marked this pull request as ready for review May 27, 2025 17:23
@anikiki anikiki merged commit 56c4821 into develop May 27, 2025
7 of 10 checks passed
@anikiki anikiki deleted the fix/ana/rename_cohorts_to_adhere_to_the_rules branch May 27, 2025 18:14
anikiki added a commit that referenced this pull request May 27, 2025
Task/Issue URL:
https://app.asana.com/1/137249556945/task/1210391900429638?focus=true

### Description
Updated cohort names in `ReactivateUsersToggles.kt` to use camelCase
format:
- Changed `duckplayer_prompt` to `duckplayerPrompt`
- Changed `browser_prompt` to `browserPrompt`

### Steps to test this PR

_Cohort naming_
- [ ] Verify that the cohort names are correctly updated in the codebase
- [ ] Ensure that any existing references to these cohorts are updated
or handle both naming formats

### NO UI changes

---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1210391900429638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants