adapt E2E tests to be compatible with the new visual design #6153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm running the E2E test suite on this branch here, just to make sure nothing broke. |
|
Tests are all green, this is ready for review. |
CDRussell
approved these changes
May 29, 2025
LukasPaczos
deleted the
fix/lukasz-p/make-e2e-tests-compatible-with-new-visual-design
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1210387720528713?focus=true
Description
Adapts the Maestro tests to successfully run with or without the new visual design.
Steps to test this PR
QA optional - visual design currently isn't enabled for any build version or flavor.
If you do want to give it a try, you can hardcode
https://www.jsonblob.com/api/1376886835833397248locally and try any of the Maestro tests, especially the ones that interact with the bottom menu/tabs buttons or privacy shield.Separately, I'll look into adding dedicated tests for the new visual design.