Skip to content

adapt PPro E2E test for possibility of trials #6154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

LukasPaczos
Copy link
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1210398081973853

Description

Adapts the special URL PPro test to assert for more generic content which doesn't get tripped up by whether there's a trial offer or not.

Steps to test this PR

QA optional. If you want to give it a try anyway, run the launch_privacy_pro_from_special_url.yaml Maestro test.

@LukasPaczos LukasPaczos enabled auto-merge (squash) May 28, 2025 14:07
@LukasPaczos LukasPaczos requested a review from nalcalag May 28, 2025 14:09
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just noting that this would only pass if the device is set to US (as I guess they are?). On a European device, 'Identity Theft Restoration' wouldn't appear

@LukasPaczos LukasPaczos merged commit 295b9fd into develop May 28, 2025
6 checks passed
@LukasPaczos LukasPaczos deleted the fix/lukasz-p/ppro-trial-e2e-test branch May 28, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants