Fix: Swiping with new UI & bottom bar #6155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
approved these changes
May 29, 2025
There was a problem hiding this comment.
As discussed on MM, this reintroduces the issue fixed in #6109 for the bottom omnibar. Let's merge as a stop-gap because the issue with tab swiping is much more severe and we can follow up with a longer-term fix for rotation separately.
| @@ -41,6 +41,7 @@ import androidx.core.transition.doOnEnd | |||
| import androidx.core.view.doOnLayout | |||
| import androidx.core.view.isInvisible | |||
| import androidx.core.view.isVisible | |||
| import androidx.lifecycle.Lifecycle | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1210392359930072?focus=true
Description
Fixes an omnibar layout bug with tab swiping when new UI is enabled and the omnibar position is set to bottom.
Steps to test this PR
Feature 1
UI changes