Skip to content

Fix: Swiping with new UI & bottom bar #6155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2025
Merged

Fix: Swiping with new UI & bottom bar #6155

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d61460
Do not collect view state updates until resumed
0nko May 28, 2025
21027f8
Unlock dimensions immediately
0nko May 28, 2025
eea8a17
Revert min collection state as it's not needed
0nko May 29, 2025
a7410d9
Only unlock content after layout done for top position
0nko May 29, 2025
6d7e839
Optimize imports
0nko May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/src/main/java/com/duckduckgo/app/browser/omnibar/experiments/FadeOmnibarLayout.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,13 @@ class FadeOmnibarLayout @JvmOverloads constructor(
if (w != oldw || h != oldh) {
// This allows the view to adjust to configuration changes, even if it's currently in the focused state.
// We need to do this after the layout pass that triggered onSizeChanged because there appears to be a race condition
// where layout param changes done directly in the onSizeChanged loop are not applied correctly.
doOnLayout {
// where layout param changes done directly in the onSizeChanged loop are not applied correctly (only applies to TOP omnibar position).
if (omnibarPosition == OmnibarPosition.TOP) {
doOnLayout {
unlockContentDimensions()
}
} else {
// For BOTTOM omnibar position, we don't wait to doOnLayout because it breaks the omnibar layout with tab swiping
unlockContentDimensions()
}
}
Expand Down
Loading