Dialog component for the onboarding design experiment #6157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new dialog component for the onboarding design experiment by adding appropriate color attributes, theming items, a background drawable, and a custom view implementation with entrance animations.
- Added new XML attributes and colors in temp_colors.xml.
- Updated theming in design-system-theming.xml to reference the new dialog background colors.
- Created a new drawable and a Kotlin view (BuckOnboardingDialogView) with entrance animations for the onboarding dialog.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common/common-ui/src/main/res/values/temp_colors.xml | Introduces new color attributes for the onboarding dialog background |
| common/common-ui/src/main/res/values/design-system-theming.xml | Updates theming items to use the new dialog background colors |
| app/src/main/res/drawable/background_buck_onboarding_dialog.xml | Provides the drawable shape using the new background attribute |
| app/src/main/java/com/duckduckgo/app/onboarding/ui/page/BuckOnboardingDialogView.kt | Implements the dialog view with entrance animations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1205648422731273/task/1210409460462702?focus=true
Description
This PR adds new dialog component for use in the upcoming onboarding design experiment.
Steps to test this PR
QA-optional
No UI changes