Skip to content

remove Privacy Pro special URL test from release tests #6158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LukasPaczos
Copy link
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/414730916066338/task/1210408722140193?focus=true

Description

Remove the Privacy Pro special URL from release tests as we can't assert correctness of this behavior on Maestro Cloud emulators.

Steps to test this PR

No QA needed.

@LukasPaczos LukasPaczos requested a review from nalcalag May 29, 2025 09:41
@LukasPaczos LukasPaczos enabled auto-merge (squash) May 29, 2025 09:41
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasPaczos I commented on Asana, but just a heads-up: if we don't have other tests that open the paywall, I’d suggest keeping this test for non-eligible users. If we ever support eligible accounts on Maestro, we can add the others then.

@LukasPaczos LukasPaczos merged commit 5c843ad into develop May 29, 2025
8 checks passed
@LukasPaczos LukasPaczos deleted the fix/lukasz-p/remove-ppro-special-url-test-from-release-tests branch May 29, 2025 10:10
@LukasPaczos
Copy link
Contributor Author

@nalcalag as we caught up on MM, the test wasn't functioning as expected before, and now the fixed version can only be run locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants