Skip to content

Remove temporary pixel to measure expired account restore while purchasing Privacy Pro #6159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

lmac012
Copy link
Contributor

@lmac012 lmac012 commented May 29, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1205648422731273/task/1209739160375703?focus=true

Description

This PR removes a pixel that was used to measure how often an expired account is restored during Privacy Pro purchase.

Steps to test this PR

Just a smoke test to ensure that removing the pixel didn't break anything

  • Purchase test subscription
  • Verify purchase was successful (can access VPN, etc.)
  • Cancel the subscription and wait for it to expire
  • Remove subscription from device
  • Purchase test subscription again
  • Verify purchase was successful

No UI changes

Copy link
Contributor Author

lmac012 commented May 29, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lmac012 lmac012 force-pushed the feature/lukasz/remove-temporary-pixel branch from c81855c to fae16f7 Compare May 29, 2025 11:47
@lmac012 lmac012 marked this pull request as ready for review May 29, 2025 11:47
@lmac012 lmac012 force-pushed the feature/lukasz/remove-temporary-pixel branch from fae16f7 to d6b8aab Compare May 29, 2025 14:46
@lmac012 lmac012 requested a review from nalcalag May 29, 2025 15:55
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected

@lmac012 lmac012 merged commit caf2e7b into develop Jun 2, 2025
10 of 11 checks passed
@lmac012 lmac012 deleted the feature/lukasz/remove-temporary-pixel branch June 2, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants