-
Notifications
You must be signed in to change notification settings - Fork 989
Onboarding Experiment: Add button styles #6167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding Experiment: Add button styles #6167
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new button styles for the onboarding experiment, including primary and secondary variants along with updated colors, layouts, and animations to support the new visual design.
- Added new typography and button styles in widgets.xml
- Defined new color resources for both light and night modes
- Updated component_buttons.xml to showcase the new button implementations
- Added new drawable and animator resources for button backgrounds and press animations
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
common/common-ui/src/main/res/values/widgets.xml | New typography and button styles added to support onboarding button designs |
common/common-ui/src/main/res/values/temp_colors.xml | New color definitions for primary and secondary button styles in light mode |
common/common-ui/src/main/res/values-night/temp_colors.xml | Night mode color resources corresponding to the new button colors |
common/common-ui/src/main/res/layout/component_buttons.xml | UI layout updated to include new primary and secondary buttons for onboarding experiment |
common/common-ui/src/main/res/drawable/buck_primary_button_background.xml | Added drawable resource for the primary button background with rounded corners |
common/common-ui/src/main/res/drawable/buck_button_primary_container_selector.xml | New state-based selector drawable for the primary button container |
common/common-ui/src/main/res/animator/buck_button_animator_set.xml | Animator resource defining press animations for the buttons |
e21530e
to
998eaa6
Compare
b7c8e3d
to
36f6367
Compare
998eaa6
to
7c9252a
Compare
36f6367
to
deaff27
Compare
7c9252a
to
fdb9546
Compare
deaff27
to
76053be
Compare
fdb9546
to
d4490cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1210435540768301
Description
Added new button styles for the onboarding experiment. Created primary and secondary "buck" button variants with custom animations, colors, and styling for both light and dark themes.
Steps to test this PR
Note: As we're using temp colors and not making this part of the theme, enabling "Dark Theme" on the ADS screen will not work.
This is of no consequence for the experiment as we'll be targeting people new to the app and we'll be using system theme settings (not app theme settings) to determine the button theme.
Button Styles
UI changes