Skip to content

Fix Translation of Subscription Settings Strings #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jun 5, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/task/1210449725813015?focus=true

Description

Split the subscription renewal information string into separate monthly and yearly resources

Steps to test this PR

  • Set a Privacy Pro eligible account
  • Set device to Polish
  • Fresh install
  • Go to Settings, and check 'Try Privacy Pro Free' is displayed in the Settings menu
  • Tap on Privacy Pro which will display the paywall screen
  • Check you see the free trial products on paywall
  • Purchase any product
  • Check Subscription Settings screen is showing status/renewal text correctly for Free Trial
  • Cancel subscription (when still on Free Trial)
  • Check Subscription Settings screen is showing status/expire text correctly for Free Trial

No UI changes

Copy link
Contributor Author

nalcalag commented Jun 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag changed the title Split subscription renewal info string into separate monthly and yearly resources Fix Translation of Subscription Settings Strings Jun 9, 2025
Copy link
Contributor

@lmac012 lmac012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nalcalag nalcalag marked this pull request as ready for review June 9, 2025 11:55
@nalcalag nalcalag merged commit d7fca2f into develop Jun 9, 2025
6 checks passed
@nalcalag nalcalag deleted the feature/noelia/subscription_settings_improvement_smartling branch June 9, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants