Recognise the proxy slot pattern #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a feature for the analyzer to recognise the commonly used proxy-slot pattern. It does this by a limited form of constant folding for values that are likely to be hashes of encoded strings. This commit also improves the analyzer by causing it to constant fold lengths in memory reads, thereby giving itself more accurate information about the values actually being passed around in the program.
kustosz
reviewed
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit implements a feature for the analyzer to recognise the commonly used proxy-slot pattern. It does this by a limited form of constant folding for values that are likely to be hashes of encoded strings.
This commit also improves the analyzer by causing it to constant fold lengths in memory reads, thereby giving itself more accurate information about the values actually being passed around in the program.
Closes #91
Closes #93
Details
The usual, please!
Checklist