Update to use cmfcmf/openweathermap-php-api ^3 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Http client and request factory discovery logic added * Readme updated to show installation additions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates moves to support version 3 of openweathermap-php-api. It adds in the new version constraint, as well as Http client and request factory discovery logic to provide the clients now required by the library. There is also additional text added to the readme to highlight the new installation requirements.
This upgrade works well for me (and I've been using a similarly edited fork for a while!) but version 3.x of the php-api has several breaking changes which will likely break some users existing code. This upgrade should therefore be semantically versioned to highlight the deprecated methods and the change to the unit labels etc.
I wonder if it would make sense to move this whole library also to version 3.x to stay in sync with the major version of openweathermap-php-api as breaking changes there will always break things for users here - and it makes that dependency clearer. I'm not sure if that might get confusing if we also need to break things for a new laravel release or other reason though.