Fix: correctly pass query params into /templates infra openapi-fetch (#77)

This pr fixes correct invocation of `/templates` infra route to get the
correct templates based on the `teamID`. Previously the query param for
`teamID` was passed outside the `params` prop, which made it look like
the query params are passed correctly, but actually they were not
applied to the final invocation url.

This resulted in the templates still being returned, but the team for
which the templates are returned was arbitrarily chosen, based on the
user details inferred from the access token. As a result, users of the
dashboard saw the same templates, regardless of their selected team.

This issue was tricky to spot, since the infra route for `/templates`
accepts this param as nullable and does not throw, but rather return the
templates for an arbitrary team.

Additionally this pr:
- improves the openapi-fetch client definition to explicitly use
next.js's version of fetch instead of globalThis.fetch
- next.js fetch logging by default, which makes issues like these easier
to spot in development
- improves the `VERBOSE` flag condition, for being able to turn of
verbose logging in development environments

Author: ben-fornefeld

next.config.mjs

@@ -17,6 +17,11 @@ const config = {
       bodySizeLimit: '5mb',
     },
   },
+  logging: {
+    fetches: {
+      fullUrl: true,
+    },
+  },
   trailingSlash: false,
   headers: async () => [
     {

src/configs/flags.ts

@@ -1,5 +1,3 @@
 export const ALLOW_SEO_INDEXING = process.env.ALLOW_SEO_INDEXING === '1'
-export const VERBOSE =
-  process.env.NODE_ENV === 'development' ||
-  process.env.NEXT_PUBLIC_VERBOSE === '1'
+export const VERBOSE = process.env.NEXT_PUBLIC_VERBOSE === '1'
 export const INCLUDE_BILLING = process.env.NEXT_PUBLIC_INCLUDE_BILLING === '1'

src/lib/clients/api.ts

@@ -3,7 +3,12 @@ import type { paths as InfraPaths } from '@/types/infra-api'
 
 export const infra = createClient<InfraPaths>({
   baseUrl: process.env.INFRA_API_URL,
-  headers: {
-    'Content-Type': 'application/json',
+  fetch: ({ url, headers, body, method, ...options }) => {
+    return fetch(url, {
+      headers,
+      body,
+      method,
+      ...options,
+    })
   },
 })

src/server/sandboxes/get-team-sandboxes.ts

@@ -33,9 +33,6 @@ export const getTeamSandboxes = authActionClient
     }
 
     const res = await infra.GET('/sandboxes', {
-      query: {
-        state: 'running',
-      },
       headers: {
         ...SUPABASE_AUTH_HEADERS(session.access_token, teamId),
       },

src/server/templates/get-team-templates.ts

@@ -33,8 +33,10 @@ export const getTeamTemplates = authActionClient
     }
 
     const res = await infra.GET('/templates', {
-      query: {
-        teamID: teamId,
+      params: {
+        query: {
+          teamID: teamId,
+        },
       },
       headers: {
         ...SUPABASE_AUTH_HEADERS(session.access_token),