-
Notifications
You must be signed in to change notification settings - Fork 45
Add: Infra OAPI & EnvD gRPC client + Sandbox Details Server Function #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Infra OAPI & EnvD gRPC client + Sandbox Details Server Function #76
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mishushakov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One thing to keep in mind is when sending requests, you should probably include the default headers:
https://github.com/e2b-dev/E2B/blob/main/packages/js-sdk/src/api/metadata.ts#L44
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include default headers:
https://github.com/e2b-dev/E2B/blob/main/packages/js-sdk/src/api/metadata.ts#L44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you elaborate which of these would be useful here? these look more like headers related to the sdk + the openapi client is never used in browser environment in this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the changes I have pending for envd get accepted then you'll have to send package_version so we can return a richer response for envd filesystem, but feel free to ignore for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we'll need to include at least browser and platform headers for our analytics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay ping me on that, but related to the upcoming changes to dashboard, package_version should probably be optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we'll need to include at least browser and platform headers for our analytics
i am not sure if we want to include dashboard analytics data through our "sdk" analytics interface
…2b-dev#76) Added infrastructure API client and envd gRPC client generation, then migrated existing infrastructure calls to use the new openapi-fetch pattern. **Key Changes:** - **Added infra API & envd gRPC client generation** - New API schema with endpoints for templates, nodes, access tokens, and API keys - **Refactored infra invocations to openapi-fetch** - Migrated from manual API calls to generated client methods across dashboard, sandboxes, templates, and team management - **Improved error handling** - Added `handleDefaultInfraError` function that informs users about billing limit blockage on 403 errors - Added correct error handing for template deletion - **Fixed build errors from `noUncheckedIndexedAccess`** - Added optional chaining in chart tooltips and cleaned up unsafe array/object access patterns **Cleanup:** - Removed unused `AssemblyLoader` component - Enabled stricter TypeScript checking for better type safety Completes E2B-2467, Completes E2B-2469, Completes E2B-2374
Added infrastructure API client and envd gRPC client generation, then migrated existing infrastructure calls to use the new openapi-fetch pattern.
Key Changes:
handleDefaultInfraErrorfunction that informs users about billing limit blockage on 403 errors - Added correct error handing for template deletionnoUncheckedIndexedAccess- Added optional chaining in chart tooltips and cleaned up unsafe array/object access patternsCleanup:
AssemblyLoadercomponentCompletes E2B-2467, Completes E2B-2469, Completes E2B-2374