Skip to content

Conversation

@ben-fornefeld
Copy link
Member

@ben-fornefeld ben-fornefeld commented Jun 10, 2025

Added infrastructure API client and envd gRPC client generation, then migrated existing infrastructure calls to use the new openapi-fetch pattern.

Key Changes:

  • Added infra API & envd gRPC client generation - New API schema with endpoints for templates, nodes, access tokens, and API keys
  • Refactored infra invocations to openapi-fetch - Migrated from manual API calls to generated client methods across dashboard, sandboxes, templates, and team management
  • Improved error handling - Added handleDefaultInfraError function that informs users about billing limit blockage on 403 errors - Added correct error handing for template deletion
  • Fixed build errors from noUncheckedIndexedAccess - Added optional chaining in chart tooltips and cleaned up unsafe array/object access patterns

Cleanup:

  • Removed unused AssemblyLoader component
  • Enabled stricter TypeScript checking for better type safety

Completes E2B-2467, Completes E2B-2469, Completes E2B-2374

@linear
Copy link

linear bot commented Jun 10, 2025

@vercel
Copy link

vercel bot commented Jun 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 3:32pm
web-juliett ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 3:32pm

Copy link
Member

@mishushakov mishushakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing to keep in mind is when sending requests, you should probably include the default headers:
https://github.com/e2b-dev/E2B/blob/main/packages/js-sdk/src/api/metadata.ts#L44

Comment on lines +6 to +8
headers: {
'Content-Type': 'application/json',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate which of these would be useful here? these look more like headers related to the sdk + the openapi client is never used in browser environment in this repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the changes I have pending for envd get accepted then you'll have to send package_version so we can return a richer response for envd filesystem, but feel free to ignore for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we'll need to include at least browser and platform headers for our analytics

Copy link
Member Author

@ben-fornefeld ben-fornefeld Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay ping me on that, but related to the upcoming changes to dashboard, package_version should probably be optional.

Copy link
Member Author

@ben-fornefeld ben-fornefeld Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we'll need to include at least browser and platform headers for our analytics

i am not sure if we want to include dashboard analytics data through our "sdk" analytics interface

@ben-fornefeld ben-fornefeld merged commit 3cb0e60 into main Jun 10, 2025
4 checks passed
@ben-fornefeld ben-fornefeld deleted the implement-grpc-client-and-api-layer-e2b-2462 branch June 10, 2025 15:39
kitchenbeats pushed a commit to kitchenbeats/botlink-dashboard that referenced this pull request Oct 20, 2025
…2b-dev#76)

Added infrastructure API client and envd gRPC client generation, then
migrated existing infrastructure calls to use the new openapi-fetch
pattern.

**Key Changes:**
- **Added infra API & envd gRPC client generation** - New API schema
with endpoints for templates, nodes, access tokens, and API keys
- **Refactored infra invocations to openapi-fetch** - Migrated from
manual API calls to generated client methods across dashboard,
sandboxes, templates, and team management
- **Improved error handling** - Added `handleDefaultInfraError` function
that informs users about billing limit blockage on 403 errors - Added
correct error handing for template deletion
- **Fixed build errors from `noUncheckedIndexedAccess`** - Added
optional chaining in chart tooltips and cleaned up unsafe array/object
access patterns

**Cleanup:**
- Removed unused `AssemblyLoader` component
- Enabled stricter TypeScript checking for better type safety

Completes E2B-2467, Completes E2B-2469, Completes E2B-2374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants