Add addons table #1337
Open
Add addons table #1337
+637
−4,592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubno
force-pushed
the
refactor-api-to-use-the-new-add-ons-table-eng-3069
branch
5 times, most recently
from
61c521c to
dd8cc31
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jakubno
force-pushed
the
refactor-api-to-use-the-new-add-ons-table-eng-3069
branch
from
a006852 to
bd08a5e
Compare
sitole
requested changes
Oct 15, 2025
| AND addon.valid_from <= now() | ||
| AND (addon.valid_to IS NULL OR addon.valid_to > now()) | ||
| ) a ON true | ||
| WHERE ut.user_id = $1 AND t.id = $2; |
There was a problem hiding this comment.
Can we create view that will precalculate addon values per team so we dont need to do this sum in multiple queries?
There was a problem hiding this comment.
Maybe sqlc comes with some way how to re-use part of query
| ctx := c.Request.Context() | ||
|
|
||
| teams, err := a.sqlcDB.GetTeamsWithUsersTeamsWithTier(ctx, userID) | ||
| teams, err := dbapi.GetTeamByUser(ctx, a.sqlcDB, userID) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds addons table and refactors API to use a unified
types.Teamwith computed limits (replacing tier usage) across auth, handlers, orchestration, and template flows.public.addonstable and migration with RLS; aggregates extra limits into team queries.teams__get.sqlreturning tier + addon extras; remove old tier-specific queries.internal/db/types: addsTeam,TeamLimits,TeamWithDefault; builds limits from tier + addons.Tierent schema and related generated code;Teamretainstieras string.*types.Team(drops tier in cache); authentication functions updated to use*types.Team.GetTeamAndTiertoGetTeamAndLimits; all handlers use*types.Teamand enforceteam.Limits(timeout, CPU/RAM checks, metrics, logs, lists, template ops).GetTeamAuth,GetTeamByUser,GetTeamByIDAndUserIDAuthconstructingtypes.Teamwith limits.team.Limits(concurrency, max length).team.Limits.*types.Team.Written by Cursor Bugbot for commit bd08a5e. This will update automatically on new commits. Configure here.