Skip to content

Conversation

djeebus
Copy link
Contributor

@djeebus djeebus commented Oct 14, 2025

Note

Introduces BuilderConfig into orchestrator config and refactors sandbox/FC to use it; centralizes telemetry initialization with internal noop handling and unexports Otel endpoint.

  • Orchestrator Config:
    • Add and embed BuilderConfig with ALLOW_SANDBOX_INTERNET, ENVD_TIMEOUT, FIRECRACKER_VERSIONS_DIR, HOST_KERNELS_DIR, ORCHESTRATOR_BASE_PATH, SANDBOX_DIR, SHARED_CHUNK_CACHE_PATH, and NetworkConfig.
    • Switch to env.ParseAs and add ParseBuilder().
  • Sandbox/Firecracker:
    • Replace env var lookups with cfg.BuilderConfig across fc (paths and script builder).
    • Update fc.NewProcess and StartScriptBuilder to accept BuilderConfig.
    • sandbox.Factory now holds BuilderConfig, uses it for internet allowance and EnvdTimeout.
  • Template Cache:
    • Use config.BuilderConfig.SharedChunkCachePath for shared cache.
  • Telemetry:
    • Centralize client init: call telemetry.New(...) unconditionally; it now returns noop if endpoint unset.
    • Unexport OTEL_COLLECTOR_GRPC_ENDPOINT var and update exporters to use it.
  • Entrypoints/Tests:
    • Adjust orchestrator, build-template cmd, and benchmarks to new config/factory signatures and imports.
    • Add tests for embedded config defaults/overrides.

Written by Cursor Bugbot for commit 6c5fe84. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants