Move paths defined in env vars into config model, split into server and builder config #1352
+104
−105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces BuilderConfig into orchestrator config and refactors sandbox/FC to use it; centralizes telemetry initialization with internal noop handling and unexports Otel endpoint.
BuilderConfig
withALLOW_SANDBOX_INTERNET
,ENVD_TIMEOUT
,FIRECRACKER_VERSIONS_DIR
,HOST_KERNELS_DIR
,ORCHESTRATOR_BASE_PATH
,SANDBOX_DIR
,SHARED_CHUNK_CACHE_PATH
, andNetworkConfig
.env.ParseAs
and addParseBuilder()
.cfg.BuilderConfig
acrossfc
(paths and script builder).fc.NewProcess
andStartScriptBuilder
to acceptBuilderConfig
.sandbox.Factory
now holdsBuilderConfig
, uses it for internet allowance andEnvdTimeout
.config.BuilderConfig.SharedChunkCachePath
for shared cache.telemetry.New(...)
unconditionally; it now returns noop if endpoint unset.OTEL_COLLECTOR_GRPC_ENDPOINT
var and update exporters to use it.Written by Cursor Bugbot for commit 6c5fe84. This will update automatically on new commits. Configure here.