Skip to content

Conversation

djeebus
Copy link
Contributor

@djeebus djeebus commented Oct 14, 2025

Note

Adds OTEL metrics for nbd/network pools and simplifies APIs by removing MeterProvider parameters, updating call sites accordingly.

  • Telemetry/metrics:
    • NBD pool (internal/sandbox/nbd/pool.go):
      • Add OTEL counters: slots_pool.ready (up/down), slots_pool.acquired, slots_pool.released.
      • Track acquisitions, releases, and ready count; change release to accept ctx.
    • Network pool (internal/sandbox/network/pool.go):
      • Add OTEL counters: slots_pool.new/reused (up/down), slots_pool.acquired (with pool attr), slots_pool.returned, slots_pool.released.
      • Use new counters in Populate, Get, Return, cleanup, Close; cleanup/Close now accept ctx.
    • Shared telemetry (shared/pkg/telemetry/meters.go):
      • Remove pool-specific UpDownCounter names now defined locally in pools.
  • API changes:
    • nbd.NewDevicePool() no longer takes a MeterProvider.
    • network.NewPool(newSize, reusedSize, nodeID, config) no longer takes a MeterProvider.
    • Update all call sites (benchmarks, CLI, orchestrator main, mock-nbd) to new signatures.

Written by Cursor Bugbot for commit bc3aa20. This will update automatically on new commits. Configure here.

@djeebus djeebus added the improvement Improvement for current functionality label Oct 14, 2025
@djeebus djeebus changed the title Expose some counters to nbd and network pools ENG-3148 Expose some counters to nbd and network pools Oct 14, 2025
Copy link

linear bot commented Oct 14, 2025

@djeebus djeebus changed the title ENG-3148 Expose some counters to nbd and network pools Expose some counters to nbd and network pools Oct 14, 2025
@djeebus djeebus marked this pull request as draft October 14, 2025 23:35
@djeebus djeebus marked this pull request as ready for review October 15, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement for current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants