Expose some counters to nbd and network pools #1353
+89
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds OTEL metrics for nbd/network pools and simplifies APIs by removing MeterProvider parameters, updating call sites accordingly.
internal/sandbox/nbd/pool.go
):slots_pool.ready
(up/down),slots_pool.acquired
,slots_pool.released
.release
to acceptctx
.internal/sandbox/network/pool.go
):slots_pool.new
/reused
(up/down),slots_pool.acquired
(withpool
attr),slots_pool.returned
,slots_pool.released
.Populate
,Get
,Return
,cleanup
,Close
;cleanup
/Close
now acceptctx
.shared/pkg/telemetry/meters.go
):nbd.NewDevicePool()
no longer takes aMeterProvider
.network.NewPool(newSize, reusedSize, nodeID, config)
no longer takes aMeterProvider
.Written by Cursor Bugbot for commit bc3aa20. This will update automatically on new commits. Configure here.