Skip to content

Compile with warnings as errors in CI #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

Compile with warnings as errors in CI #1103

merged 1 commit into from
Sep 16, 2025

Conversation

@Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Jul 28, 2025 •
edited by MiguelCompany
Loading

Description

Fast DDS Docs CI does not compile with warnings as errors enabled, so relevant warnings (e.g: deprecation warnings) are ignored. This PR fixes it.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Merge after:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • _N/A: Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Carlosespicur Carlosespicur modified the milestones: v3.4.0, v3.3.1 Jul 28, 2025
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 28, 2025 12:42
@MiguelCompany
Copy link
Member

MiguelCompany commented Jul 28, 2025

@Mergifyio backport 3.3.x 3.2.x 2.14.x

@mergify
Copy link

mergify bot commented Jul 28, 2025 •
edited
Loading

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

@Carlosespicur
Compile with warnings as errors in CI
1703d17 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur force-pushed the hotfix/warnings-as-errors branch from 25779ca to 1703d17 Compare July 28, 2025 14:18
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany September 16, 2025 11:02
@MiguelCompany MiguelCompany mentioned this pull request Sep 16, 2025
Merged
13 tasks
This was referenced Sep 16, 2025
Merged
Merged
@MiguelCompany MiguelCompany merged commit 66348dc into master Sep 16, 2025
4 of 6 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/warnings-as-errors branch September 16, 2025 15:52
mergify bot pushed a commit that referenced this pull request Sep 16, 2025
@Carlosespicur @mergify
Compile with warnings as errors in CI (#1103)
fd190d4 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 66348dc)
mergify bot pushed a commit that referenced this pull request Sep 16, 2025
@Carlosespicur @mergify
Compile with warnings as errors in CI (#1103)
3d0ddc5 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 66348dc)
This was referenced Sep 16, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 16, 2025
@Carlosespicur @mergify
Compile with warnings as errors in CI (#1103)
0f3f811 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 66348dc)

# Conflicts:
#	.github/workflows/config/build.meta
@mergify mergify bot mentioned this pull request Sep 16, 2025
Open
6 tasks
MiguelCompany pushed a commit that referenced this pull request Sep 18, 2025
@mergify @Carlosespicur
Compile with warnings as errors in CI (#1103) (#1122)
4952102 
(cherry picked from commit 66348dc)

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request Sep 18, 2025
@mergify @Carlosespicur
Compile with warnings as errors in CI (#1103) (#1123)
81666f7 
(cherry picked from commit 66348dc)

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v3.4.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

3 participants

@Carlosespicur @MiguelCompany