Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 5, 2025

Description

This PR attempts to solve the data race produced when a thread clears the attributes of PDPStatelssWriter at mark_all_readers_interested (called in announceParticipantState from events thread, for example), while the values are read from another thread (send_to_fixed_locators called, for example, from the asynchronous send thread → LocatorSelectorSender::send → StatelessWriter::send_nts → PDPStatelessWriter::send_to_fixed_locators).

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #6100 done by [Mergify](https://mergify.com).

* Refs #23822. Protect PDPStatelessWriter attributes

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

* Refs #23822. Atomize matched_ attribute

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

* Refs #23822. Protect reader_data_filter_ attribute

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

---------

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
(cherry picked from commit 6ca678b)
@MiguelCompany MiguelCompany added this to the v3.2.4 milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants