Skip to content

Add UI support for Discovery Server setting_draft #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

MMarcus95
Copy link

@MMarcus95 MMarcus95 commented Jan 24, 2025

This PR adds the possibility to discover and visualize topics in Plotjuggler when using Discovery Server setting.

The UI has been changed as follows

Screenshot from 2025-01-24 12-44-20

How to use

As in the current behavior, when the Select DDS message window appears, by default a domain participant in the Current DomainId domain is created, which uses Simple Discovery.

To allow Plotjuggler to discover topics when using Discovery Server setting you need to:

  • set the server ip in the server IP field
  • set the server port in the server port field
  • enable the Discovery Server setting by clicking on the button OFF

Once the Discovery Server setting is enable, you will see:

  • the button changing to ON
  • the Change Domain button becoming gray, meaning that when the Discovery Server setting is ON you cannot use Simple Discovery, avoiding to mix incompatible discovery settings

Screenshot from 2025-01-24 12-44-58

When the Discovery Server setting is turned off by clicking the ON button, a domain participant is created in the Current DomainId domain using Simple Discovery and the possibility use Simple Discovery and to change the domain is restored.

Notice that server IP and server port need to be set before starting the discovery server, so when the button is in OFF state.

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@MMarcus95 MMarcus95 marked this pull request as draft January 24, 2025 12:47
MMarcus95 and others added 4 commits January 24, 2025 14:07
Signed-off-by: Marco Marchitto <marco.marchitto@iit.it>
Signed-off-by: eProsima <jesuspoderoso@eprosima.com>
Signed-off-by: eProsima <jesuspoderoso@eprosima.com>
Signed-off-by: Marco Marchitto <marco.marchitto@iit.it>
@MMarcus95 MMarcus95 force-pushed the feature/discovery-server branch from b34ad31 to 753268a Compare January 24, 2025 13:09
@MMarcus95 MMarcus95 marked this pull request as ready for review January 24, 2025 13:13
@MMarcus95 MMarcus95 marked this pull request as draft January 24, 2025 13:15
@MMarcus95 MMarcus95 marked this pull request as ready for review January 24, 2025 13:20
@MMarcus95 MMarcus95 marked this pull request as draft January 24, 2025 13:25
@MMarcus95 MMarcus95 changed the title Add UI support for Discovery Server setting Add UI support for Discovery Server setting_draft Jan 24, 2025
@MMarcus95 MMarcus95 closed this Jan 24, 2025
@MMarcus95 MMarcus95 deleted the feature/discovery-server branch January 24, 2025 13:32
@MMarcus95
Copy link
Author

Closed in favor of #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants