Skip to content

Fix further reference expansion for package names #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix further reference expansion for package names #182

wants to merge 1 commit into from

Conversation

adamretter
Copy link
Contributor

No description provided.

duncdrum
duncdrum requested changes Feb 16, 2018
View reviewed changes
Copy link
Contributor

@duncdrum duncdrum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR changes outgoing links in the old contents data/db4-versions/*.xml but not in the current documentation pages in data/*/*.xml, e.g.:

https://github.com/eXist-db/documentation/blob/master/src/main/xar-resources/data/incompatibilities/incompatibilities.xml#L49

If there are bad links they need to be fixed in the current pages, not the old.

@duncdrum duncdrum added this to the 4.0.1 milestone Feb 16, 2018
@adamretter
Copy link
Contributor Author

@duncdrum I fixed all the bad links I could find with grep regardless of where they were. Do you see any other bad links?

@duncdrum
Copy link
Contributor

@adamretter I can't search in a fork here on GitHub but I count roughly 20 in total, note that only the old files use ulink docbook 5 uses xlink:href="{fundocs}

This was referenced Feb 26, 2018
Closed
Closed
duncdrum referenced this pull request in duncdrum/documentation Mar 2, 2018
@duncdrum
minor fixes
edba6f7 
increase issue templage default version
fix dangling reference expanders close #180, #182
switch to new map syntax in listings (not yet in app code) close eXist-db#189
@duncdrum duncdrum mentioned this pull request Mar 2, 2018
Merged
@duncdrum
Copy link
Contributor

duncdrum commented Mar 4, 2018

Changes were merged as part of #190, and #188

@duncdrum duncdrum closed this Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncdrum duncdrum duncdrum requested changes

@dizzzz dizzzz dizzzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@adamretter @duncdrum @dizzzz