Skip to content

Skywalker generates a skywalkerConfig.cmake #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Skywalker generates a skywalkerConfig.cmake #37

wants to merge 2 commits into from

Conversation

odiazib
Copy link
Contributor

@odiazib odiazib commented Jan 5, 2024

Skywalker will generate the skywalkerConfig.cmake. Then, one can use FIND_PACKAGE .

@odiazib odiazib requested a review from jeff-cohere January 5, 2024 15:45
jeff-cohere
jeff-cohere approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@jeff-cohere jeff-cohere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Have you tested this with TChem?

The only comment I have is that maybe we should use lowercase commands (include instead of INCLUDE, install instead of INSTALL) to match the CMake styling that was there. But this isn't super important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-cohere jeff-cohere jeff-cohere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odiazib @jeff-cohere