This repository was archived by the owner on Sep 4, 2020. It is now read-only.
Feature/164403270 sync tsnes with legend #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new component to render filtered tSNE plot
Pull Request Test Coverage Report for Build 322
💛 - Coveralls |
monicajianu
reviewed
Mar 27, 2019
monicajianu
reviewed
Mar 27, 2019
| symbolHeight: 5, | ||
| symbolWidth: 450 | ||
| }, | ||
| plotOptions: { |
Collaborator
There was a problem hiding this comment.
Good spot! This component used to have plot options, but it looks like a was a little overzealous last time I modified the tooltip, and left behind some invalid Highcharts options (see line 91). Could you remove them so we don't have invalid options lying around?
Contributor
Author
There was a problem hiding this comment.
Yes. This plotOptions I added is to make all points same style after gene expression json payload is clustered into multiple series as well. I cannot access the line 91 by the link. Where is the invalid Highcharts options you would like to remove?
monicajianu
reviewed
Mar 27, 2019
src/GeneExpressionTSnePlot.js
Outdated
| series={_colourizeExpressionLevel(expressionGradientColours, highlightClusters, props.cluster)(plotData)} | ||
| highchartsConfig={highchartsConfig} | ||
| loading={loading} | ||
| eventEmitter={props.eventEmitter} |
Collaborator
There was a problem hiding this comment.
Please add eventEmitter to const { } = props on line 61.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature branch is implemented to synch cluster and gene expression tSNE plots by clicking the cluster's legend. The json payload for gene expression is fetched from new endpoints introduced in atlas. As we can not set react states directly from the highcharts event function, we use the nodejs
eventEmitterto pass the legend's name and visibility to the scatter plots.