Drop ThunderstoreVersion references from ThunderstoreMod

Commonly used version-specific data - latest version number, icon and
description are now stored in the ThunderstoreMod object. Rest of the
version info needs to be fetched separately where it's actually used.

This change drastically reduces memory usage for larger communities
like Lethal Company.

Author: anttimaki

src/components/views/DownloadModModal.vue

@@ -77,7 +77,7 @@
                 <ul class="list">
                     <li class="list-item" v-for='(mod, index) in $store.getters["profile/modsWithUpdates"]'
                         :key='`to-update-${index}-${mod.getFullName()}`'>
-                        {{mod.getName()}} will be updated to: {{mod.getLatestVersion().getVersionNumber().toString()}}
+                        {{mod.getName()}} will be updated to: {{mod.getLatestVersion()}}
                     </li>
                 </ul>
             </template>
@@ -223,7 +223,7 @@ let assignId = 0;
         async getModVersions() {
             this.currentVersion = null;
             if (this.thunderstoreMod !== null) {
-                this.selectedVersion = this.thunderstoreMod.getLatestVersion().getVersionNumber().toString();
+                this.selectedVersion = this.thunderstoreMod.getLatestVersion();
                 this.recommendedVersion = null;
 
                 this.versionNumbers = await PackageDb.getPackageVersionNumbers(

src/components/views/OnlineModList.vue

@@ -4,7 +4,7 @@
             v-for='(key, index) in pagedModList' :key="`online-${key.getFullName()}-${index}-${settings.getContext().global.expandedCards}`"
             :image="getImageUrl(key)"
             :id="index"
-            :description="key.getLatestVersion().getDescription()">
+            :description="key.getDescription()">
             <template v-slot:title>
                 <span v-if="key.isPinned()">
                     <span class="tag is-info margin-right margin-right--half-width"
@@ -121,9 +121,7 @@ export default class OnlineModList extends Vue {
     }
 
     getImageUrl(mod: ThunderstoreMod): string {
-        return CdnProvider.replaceCdnHost(
-            mod.getLatestVersion().getIcon()
-        );
+        return CdnProvider.replaceCdnHost(mod.getIcon());
     }
 
     async created() {

src/components/views/OnlineModView.vue

@@ -147,7 +147,7 @@ export default class OnlineModView extends Vue {
         const searchKeys = SearchUtils.makeKeys(this.thunderstoreSearchFilter);
         if (searchKeys.length > 0) {
             searchableList = this.sortedThunderstoreModList.filter((x: ThunderstoreMod) => {
-                return SearchUtils.isSearched(searchKeys, x.getFullName(), x.getLatestVersion().getDescription())
+                return SearchUtils.isSearched(searchKeys, x.getFullName(), x.getDescription())
             });
         }
         if (!allowNsfw) {

src/model/ThunderstoreMod.ts

@@ -1,7 +1,7 @@
 import ThunderstoreVersion from './ThunderstoreVersion';
+import VersionNumber from './VersionNumber';
 
 export default class ThunderstoreMod extends ThunderstoreVersion {
-    private versions: ThunderstoreVersion[] = [];
     private rating: number = 0;
     private owner: string = '';
     private packageUrl: string = '';
@@ -14,6 +14,7 @@ export default class ThunderstoreMod extends ThunderstoreVersion {
     private categories: string[] = [];
     private hasNsfwContent: boolean = false;
     private donationLink: string | undefined;
+    private latestVersion: string = '';
 
     public static parseFromThunderstoreData(data: any): ThunderstoreMod {
         const mod = new ThunderstoreMod();
@@ -24,43 +25,37 @@ export default class ThunderstoreMod extends ThunderstoreVersion {
         mod.setDateUpdated(data.date_updated);
         mod.setDeprecatedStatus(data.is_deprecated);
         mod.setPinnedStatus(data.is_pinned);
-        const versions = [];
-        for (const version of data.versions) {
-            versions.push(new ThunderstoreVersion().make(version));
-        }
-        mod.setVersions(versions);
-        mod.setDownloadCount(
-            mod.versions
-                .map(version => version.getDownloadCount())
-                .reduce((x, y) => x + y)
-        );
         mod.setRating(data.rating_score);
         mod.setTotalDownloads(
-            mod.getVersions()
-                .map(x => x.getDownloadCount())
-                .reduce((x, y) => x + y)
+            data.versions.reduce(
+                (x: number, y: {downloads: number}) => x + y.downloads,
+                0
+            )
         );
         mod.setPackageUrl(data.package_url);
         mod.setCategories(data.categories);
         mod.setNsfwFlag(data.has_nsfw_content);
         mod.setDonationLink(data.donation_link);
+        mod.setLatestVersion(data.versions[0].version_number);
+        mod.setDescription(data.versions[0].description);
+        mod.setIcon(data.versions[0].icon);
         return mod;
     }
 
-    public getVersions(): ThunderstoreVersion[] {
-        return this.versions;
+    public getLatestVersion(): string {
+        return this.latestVersion;
     }
 
-    public setVersions(versions: ThunderstoreVersion[]) {
-        this.versions = versions;
+    public setLatestVersion(versionNumber: string) {
+        this.latestVersion = versionNumber;
     }
 
-    public getLatestVersion(): ThunderstoreVersion {
-        return this.getVersions().reduce(reduceToNewestVersion);
+    public getLatestVersionNumber(): VersionNumber {
+        return new VersionNumber(this.latestVersion);
     }
 
     public getLatestDependencyString(): string {
-        return `${this.getFullName()}-${this.getLatestVersion().toString()}`;
+        return `${this.getFullName()}-${this.getLatestVersion()}`;
     }
 
     public getRating(): number {

src/store/modules/TsModsModule.ts

@@ -80,8 +80,7 @@ export const TsModsModule = {
                 if (tsMod === undefined) {
                     state.cache.set(cacheKey, {tsMod: undefined, isLatest: true});
                 } else {
-                    const latestVersionNumber = tsMod.getLatestVersion().getVersionNumber();
-                    const isLatest = mod.getVersionNumber().isEqualOrNewerThan(latestVersionNumber);
+                    const isLatest = mod.getVersionNumber().isEqualOrNewerThan(tsMod.getLatestVersionNumber());
                     state.cache.set(cacheKey, {tsMod, isLatest});
                 }
             }

src/utils/Deprecations.ts

@@ -52,6 +52,10 @@ export class Deprecations {
         deprecationMap.set(mod.getFullName(), false);
         return false;
 
+        // TODO: version information was dropped from ThunderstoreMod to
+        // save memory. Accessing dependencies weren't added to the class
+        // since it's not currently used anywhere. Consider adding a
+        // method for this purpose if this code is ever actually used.
         // for (const dependencyNameAndVersion of mod.getLatestVersion().getDependencies()) {
         //     const dependencyName = dependencyNameAndVersion.substring(0, dependencyNameAndVersion.lastIndexOf('-'));
 

test/jest/__tests__/utils/utils.getDeprecatedPackageMap.ts.spec.ts

@@ -227,10 +227,11 @@ const createStubMod = (
     mod.setFullName(modName);
     mod.setDeprecatedStatus(deprecated);
 
-    const version = new ThunderstoreVersion();
-    version.setFullName(`${mod}-1.0.0`);
-    version.setDependencies(dependencyNames.map((depName) => `${depName}-1.0.0`));
-    mod.setVersions([version]);
+    // TODO: ThunderstoreMod no longer carries information about versions.
+    // const version = new ThunderstoreVersion();
+    // version.setFullName(`${mod}-1.0.0`);
+    // version.setDependencies(dependencyNames.map((depName) => `${depName}-1.0.0`));
+    // mod.setVersions([version]);
 
     return mod;
 }