Drop .fromReactive() from ThunderstoreMod and ThunderstoreVersion

As far as I can tell, the conversion isn't really needed. The doc
strings of ReactiveObjectConverterInterface claims that access to class
methods is lost, but based on testing this is not true. Another claim
is that this grants access to object's private fields. The fields can
be accessed, but same is true to any ThunderstoreMod object, even if
they aren't passed through Vue's methods. Aside from getting a clear
TypeScript warning about accessing a private field in IDE (compile
time) nothing prevents accessing the field in JS files (run time).

Ideally this might speed up OnlineModList rendering, as the unnecessary
object creation is skipped.

Author: anttimaki

src/components/views/OnlineModList.vue

@@ -100,33 +100,29 @@ export default class OnlineModList extends Vue {
         return this.$store.state.tsMods.deprecated;
     }
 
-    isModDeprecated(key: any) {
-        const mod: ThunderstoreMod = new ThunderstoreMod().fromReactive(key);
+    isModDeprecated(mod: ThunderstoreMod) {
         return this.deprecationMap.get(mod.getFullName()) || false;
     }
 
-    isThunderstoreModInstalled(vueMod: any) {
-        const mod: ThunderstoreMod = new ThunderstoreMod().fromReactive(vueMod);
+    isThunderstoreModInstalled(mod: ThunderstoreMod) {
         return this.localModList.find((local: ManifestV2) => local.getName() === mod.getFullName()) != undefined;
     }
 
-    showDownloadModal(mod: any) {
-        const modToDownload = new ThunderstoreMod().fromReactive(mod);
-        this.$store.commit("openDownloadModModal", modToDownload);
+    showDownloadModal(mod: ThunderstoreMod) {
+        this.$store.commit("openDownloadModModal", mod);
     }
 
     getReadableDate(date: Date): string {
         return valueToReadableDate(date);
     }
 
-    getReadableCategories(tsMod: ThunderstoreMod) {
-        const mod = new ThunderstoreMod().fromReactive(tsMod);
+    getReadableCategories(mod: ThunderstoreMod) {
         return mod.getCategories().join(", ");
     }
 
-    getImageUrl(tsMod: ThunderstoreMod): string {
+    getImageUrl(mod: ThunderstoreMod): string {
         return CdnProvider.replaceCdnHost(
-            tsMod.getLatestVersion().getIcon()
+            mod.getLatestVersion().getIcon()
         );
     }
 

src/model/ThunderstoreMod.ts

@@ -1,7 +1,6 @@
 import ThunderstoreVersion from './ThunderstoreVersion';
-import ReactiveObjectConverterInterface from './safety/ReactiveObjectConverter';
 
-export default class ThunderstoreMod extends ThunderstoreVersion implements ReactiveObjectConverterInterface {
+export default class ThunderstoreMod extends ThunderstoreVersion {
     private versions: ThunderstoreVersion[] = [];
     private rating: number = 0;
     private owner: string = '';
@@ -48,26 +47,6 @@ export default class ThunderstoreMod extends ThunderstoreVersion implements Reac
         return mod;
     }
 
-    public fromReactive(reactive: any): ThunderstoreMod {
-        this.setName(reactive.name);
-        this.setFullName(reactive.fullName);
-        this.setOwner(reactive.owner);
-        this.setPackageUrl(reactive.packageUrl);
-        this.setDateCreated(reactive.dateCreated);
-        this.setDateUpdated(reactive.dateUpdated);
-        this.setDeprecatedStatus(reactive.deprecated);
-        this.setPinnedStatus(reactive.pinned);
-        this.setVersions(reactive.versions.map((x: ThunderstoreVersion) => new ThunderstoreVersion().fromReactive(x)));
-        this.setDownloadCount(reactive.downloadCount);
-        this.setRating(reactive.rating);
-        this.setTotalDownloads(reactive.totalDownloads);
-        this.setUuid4(reactive.uuid4);
-        this.setCategories(reactive.categories);
-        this.setNsfwFlag(reactive.hasNsfwContent);
-        this.setDonationLink(reactive.donationUrl);
-        return this;
-    }
-
     public getVersions(): ThunderstoreVersion[] {
         return this.versions;
     }

src/model/ThunderstoreVersion.ts

@@ -1,8 +1,7 @@
 import VersionNumber from './VersionNumber';
-import ReactiveObjectConverterInterface from './safety/ReactiveObjectConverter';
 import CdnProvider from '../providers/generic/connection/CdnProvider';
 
-export default class ThunderstoreVersion implements ReactiveObjectConverterInterface {
+export default class ThunderstoreVersion  {
 
     private name: string = '';
     private versionNumber: VersionNumber = new VersionNumber('0.0.0');
@@ -32,19 +31,6 @@ export default class ThunderstoreVersion implements ReactiveObjectConverterInter
         return this;
     }
 
-    public fromReactive(reactive: any): ThunderstoreVersion {
-        this.setName(reactive.name);
-        this.setVersionNumber(new VersionNumber('0.0.0').fromReactive(reactive.versionNumber));
-        this.setDependencies(reactive.dependencies);
-        this.setFullName(reactive.fullName);
-        this.setDescription(reactive.description);
-        this.setIcon(reactive.icon);
-        this.enabled = reactive.enabled;
-        this.setDownloadCount(reactive.downloadCount);
-        this.setDownloadUrl(reactive.downloadUrl);
-        return this;
-    }
-
     public getName(): string {
         return this.name;
     }