Time bubble #1448
Closed
Time bubble #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anttimaki
commented
Sep 17, 2024
anttimaki
commented
- Proof of concept for filtering the list of available mods based on dates
- There's still no proper specification for how we want the feature to actually work and look like
We need the field on ThunderstoreVersion to be able to filter out mods and versions that are published before/after given dates. Since ThunderstoreMod inherits from ThunderstoreVersion, it will still have access to its own dateCreated field as previously. Since the field is already present in data returned from Thunderstore API for each version, no further changes are needed for populating the field into ThunderstoreVersion object.
The change makes filterModVersions(), which is used for filtering out all but a target version of a mod loader package, to work similarly to filterModVersionsByDate(), which is used to filter the older/newer versions of packages to ensure compatibility with a specific game version.
Passed to Array.sort(), the comprarer sorts mods to the default order returned by Thunderstore API's package listing endpoints.
This helper can be used to filter mod versions by start and/or end date. If all versions of a mod are filtered out, the whole mod is also removed. The idea is to create a "Time Bubble" feature. User could choose per profile the dates between which the online mod list is filtered. Intended use case is game updates breaking mods: if user updates the game, they can filter out older versions to see only the mods that have been updated after the breaking change. If user sticks to the old version of the game, they can filter out newer mods that don't work on their version, and avoid recommendations to update mods that would just break things.
|
Closing the PoC branch due to lack of traction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.