Add new ImmutableProfile class that doesn't track the active profile #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of a larger refactoring effort aiming to remove the business login from components so it can eventually be exported to be a responsibility of a CLI tool. Instead of inheritance, both classes only implement an interface defining the common methods. This was done so that when a function expects one of the classes, it won't accept the other. Being strict about this makes it easier to see which part of the code base depend on the active profile, and might reduce cases where passing wrong type of object results in unexpected behaviour. The code duplication caused by this within the classes seems like a small price to pay. The static method for accessing the root dir of all profiles was renamed to getRootDir() to make it clearer what directory it actually returns. The method is not available on ImmutableProfile, since it depends on the state of the app (active game) via PathResolver. We'll likely add a non-static method to ImmutableProfile in a later commit to reduce the dependency to app state where it's not required.
In retrospect IDK if this cleaned up the code as I thought it would.
These can be used to take an immutable snapshot of the currently active profile.
VilppeRiskidev
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a larger refactoring effort aiming to remove the
business logic from components so it can eventually be exported to be
a responsibility of a CLI tool.