Complete ImportProfileModal.profileCreatedCallback refactoring #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the method names weren't very good to start with, and others no longer fit the functionality after the recent refactoring.
- Don't handle errors here, let them flow to call site instead - Reduce looping by gathering list of disabled mods separately
- Change the method to accept ImmutableProfile as a parameter to separate it from the UI component state - Move the method to ProfileUtils as a standalone function - Include installModAfterDownload functionality in installModsToProfile as the former is no longer needed
Use ImmutableProfile for installing the mods. Especially when updating an existing profile this saves us from switching between the temporary and target profiles. Active profile is now only updated if the import process finishes successfully.
Download provider will now handle only the downloading, as fitting its moniker. Casting one type of object presenting a mod to another type is done in a separate helper function. This will eventually reduce the number of arguments passed around between different functions.
- Move parts of profileCreatedCallback to ProfileUtils - Absorp the functionality from downloadAndSaveMods directly into profileCreatedCallback, as the method has been greatly reduced in size by previous refactoring, and the readability of the code no longer warrants this separation - As far as I'm concerned, the refactoring of this particular method is now completed: all that remains in the method is reading and updating the state of the component and the app, and all business logic has been moved behind three external methods. While the three could be combined into one, it would IMO then become too big of a function - Rename the method to importProfile, since it's not really a callback function
VilppeRiskidev
approved these changes
Oct 9, 2024
Base automatically changed from
callbackless-downloadImportedProfileMods
to
develop
October 14, 2024 12:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.