Limit profile name length to prevent file system level errors #1493
Conversation
|
Added a maxlength to profile name input. I can't seem to get it to fail silently anymore. The error message if/when it does fail is still not very user friendly, but I didn't figure out a way to reliably tell what caused the error. |
There was a problem hiding this comment.
@VilppeRiskidev Based on the branch name, did you test this on profile importing? There the recent refactorings have made the errors visible. But the problem applies also when installing mods normally, and there the error is still unhandled and download modal hangs forever. Note that this seems to be TSMM issue - it looks like on R2MM the node backend handles the longer paths ok. The fix will probably need to be done on the DownloadModModal on R2MM side though.
VilppeRiskidev
force-pushed
the
importing-error-handling
branch
from
639e5b4 to
b9a041a
Compare
VilppeRiskidev
force-pushed
the
importing-error-handling
branch
from
2af8233 to
d83fb23
Compare
|
@VilppeRiskidev closing this now due to path lengths being handled via changes done in other PRs. |
No description provided.