Discard profile if importing fails midway through the process #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If importing a profile fails while copying files, the resulting profile is unlikely to be what the user expects it to be, so delete the profile folder. The process can't be resumed, so any retry will do all the work (besides downloading the mods) again anyway. When creating a new profile, it's the newly created profile folder. When updating an existing profile, it's the temporary work folder. On the UI/state management side, we need to check if the profile exists or not, and update the profile list accordingly.
VilppeRiskidev
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If importing a profile fails while copying files, the resulting profile is unlikely to be what the user expects it to be, so delete the profile folder. The process can't be resumed, so any retry will do all the work (besides downloading the mods) again anyway.
When creating a new profile, it's the newly created profile folder. When updating an existing profile, it's the temporary work folder.
On the UI/state management side, we need to check if the profile exists or not, and update the profile list accordingly.