Disable modal buttons when in progress #1532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Brownie points for the separation of commits 👍🏻
Create/rename forms can be submitted with enter, and as they do an extra check before calling the method that sets the xInProgress variable, they can be triggered twice. I realise that double-submit with enter is less likely than with a mouse click, but for completeness sake we could start the keyup.enter methods with !xInProgress?
…ple attempts at the same time
VilppeRiskidev
force-pushed
the
disable-modal-buttons-when-in-progress
branch
from
0dcb2b2 to
971b048
Compare
anttimaki
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.