Add support for remote CDN configuration #1696
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thunderstore is migrating to another CDN provider, and the change is to be done as a gradual rollout. To avoid requiring a new release for each rollout change, the mod manager will be changed to read the CDN configuration from an online source. The requirements of this task requires a more complicated data structure than the simple array used previously. Firstly we want to control the percentage of requests that are sent to old main CDN and the new main CDN. Secondly we want to test the change with only package downloads first, meaning other CDN dependant operations should only use the old main and mirror CDNs. Thirdly when the mirror CDN is selected, portion of the requests are not directed to the new CDN so users have a way to opt out should problems arise. It should be noted the implementation was kept as simple as it could given the requirements above. Therefore it might make sense to revisit the implementation once the rollout is complete, all operations can use the new CDN, and the requirements may have changed.
This is used to gradually test the new CDN Thunderstore is migrating to.
Ability to change CDN config without having to make a new mod manager release comes in handy when Thunderstore gradually migrates from one CDN provider to another.
Time it takes to make the connection check has increased as the CDN configuration is first read from online. Since the first render of the mod manager takes place after the IPC related things are executed, it makes sense to execute the check only after them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR todo:
While the changes as-is shouldn't break anything if released now, they won't actually do anything either before the aforementioned steps are completed.