Release 3.2.1 (Develop) #1836
Merged
Release 3.2.1 (Develop) #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-close ProfileManagementModal on file export
Refs TS-2484
Also removed profileList in favour of direct store access Refs TS-2484
Refs TS-2484
DownloadMixin to Composable
ProfilesMixin to Composable
Ported CategoryFilterModal to Composition API
Ported ErrorModal to Composition API
Ported CategorySelectorModal to Composition API
Ported GameRunningModal to Composition API
Convert imports to relative
This dummy game is no longer available when the Thunderstore ecosystem schema acts as the source of truth for available games. SUBDIR_NO_FLATTEN tracking method has some generic tests in Installer.Tests.spec.ts so dropping them shouldn't affect test coverage.
Install rules are now defined by the Thunderstore ecosystem data, so the files are no longer needed.
After moving from hard coded values to using Thunderstore ecosystem data as the source of truth, the class has become a stub and can be merged with the other class that contains rest of the related code.
This allows importing Enums so they don't have to be redefined in the mod manager.
To avoid having to change all the usages of enums now controlled by Thunderstore ecosystem, use regexp to cast the enum keys to the format used by the mod manager. We need to resort to regexp as the ecosystem uses kebab-case and we can't control how Quicktype generates the keys from the values.
There's a change that people who've selected a default game previously need to reselect it as the values in SettingsDexieStore change a bit, but I don't consider doing a proper migration worth the effort.
Drop an extra step from mapping PackageLoader to package loader/plugin installer. While installers probably shouldn't be bound to the loader, at least for plugins, at least the approach is not a bit simpler. Potential future work includes further simplifying the mapping by adding a "NoOpInstaller" that can be returned for PackageLoader.None, and a "LegacyPluginInstaller" that wraps the old InstallRuleInstaller in PackageInstaller interface for PackageLoaders that currently return null from getPluginInstaller. This is out of the current scope as it would require changes to GenericProfileInstaller. Furthermore, the changes would become obsolete when TCLI handles the installations.
Thunderstore ecosystem integration
Refactor and fix unit tests for InstallRuleInstaller
Remove InstallRule definition files
Merge InstallationRuleApplicator to InstallationRules
Use enums provided Thunderstore ecosystem
Dropped vue class component and decorator dependencies
- Schema change: add optional shortDescription field to community data. This field is not currently used in the mod managers - Remove InstallRules and RelativeFileExclusions from Painting VR. The game uses recursive MelonLoader, and neither of these fields are used with it. How the fields got populated in the first place is a mystery to me, but as the extraction code is no longer used, spending time debugging the issue makes no sense either - Update PEAK links - Add new mod loader package for PEAK
Update Thunderstore ecosystem schema and data
…UpdateAllInstalledModsModal is opened. * Previously when there either were no installed mods, or all mods were up to date, the modal produced an error.
* Unhandled errors were generated when the user was trying to copy the contents of a non-existent log file.
* The background was transparent, thus showing the download list through itself when scrolling
Prevent unhandled errors from happening when log file doesn't exist
Display correct information when there are no mods to update and the …
Add a background color to the buttons' sticky toolbar on DownloadMonitor
Release 3.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.