Fixed launch args in help section for Linux under Native launch behaviour #1851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebkr
force-pushed
the
proton-settings-selection
branch
2 times, most recently
from
e7e172e to
e7ff78b
Compare
|
Based on the number of conflicting files it might be good idea to rebase this before review. |
ebkr
force-pushed
the
linux-help-launch-args-display
branch
from
403e2d7 to
f7130b9
Compare
It seems the code was jumping through extra hoops that might be required when dealing with integer enums, but are unnecessary for string based enums like LaunchType. Things could perhaps be further simplified if LaunchType was used instead of string when typing SettingsDexieStore, and/or if it would be okay for ManagerSettings to return "AUTO" when the value is undefined.
anttimaki
approved these changes
Aug 27, 2025
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native
Proton