I18n/profiles #1875
Open
I18n/profiles #1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
approved these changes
Aug 21, 2025
| @@ -214,7 +219,7 @@ export const TsModsModule = { | |||
| commit('startThunderstoreModListUpdate'); | |||
|
|
|||
| try { | |||
| commit('setThunderstoreModListUpdateStatus', 'Checking for mod list updates from Thunderstore...'); | |||
| commit('setThunderstoreModListUpdateStatus', 'checkingForUpdates'); | |||
There was a problem hiding this comment.
Is it possible to call the translations here? If yes, what are your thoughts on doing so? It does muddy the waters a bit between separation of concerns, but on the other hand having a magic string here, that then gets parsed into the translation key on the template is a bit hard to follow for the reader. Or alternatively have the entire translation key present here, making it more obvious it's a translation key?
Closed
- Only added English translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.