-
Notifications
You must be signed in to change notification settings - Fork 18
Adds QualifierElement component #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the implementation of Qualifiers. I will have a look at the visuals. But this is a good start. I will just change a few things.
I noticed a small bug where qualifiers are displayed twice. I tested this for example with the standardized SMTs. The multiplicity qualifiers are always there twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new QualifierElement
component to display qualifier details and integrates it into the SubmodelElementView
.
- Adds
QualifierElement.vue
for rendering kinds, semantic IDs, value types, and values of qualifiers. - Updates
SubmodelElementView.vue
to conditionally display the new qualifier component with dividers.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
aas-web-ui/src/components/UIComponents/QualifierElement.vue | New component for rendering qualifier details |
aas-web-ui/src/components/SubmodelElementView.vue | Integrates QualifierElement and adds divider logic |
Comments suppressed due to low confidence (1)
aas-web-ui/src/components/UIComponents/QualifierElement.vue:85
- The
qualifierArray
prop defaults to an empty object, which may trigger runtime warnings. Change its type toArray
(e.g.,type: Array as PropType<Qualifier[]>
) and default to an empty array (default: () => []
).
default: {} as any,
Sorry, I missed deleting tmp code for testing purpose. It's fixed |
Thanks in advance! |
Description of Changes
This PR adds a component for qualifier.
@aaronzi Please feel free to adapt the design. I'm not satisfied with the design myself, but I don't currently have a better idea for the implementation.
Related Issue
Closes #398