Skip to content

Conversation

seicke
Copy link
Member

@seicke seicke commented Jun 24, 2025

Description of Changes

This PR adds a component for qualifier.

@aaronzi Please feel free to adapt the design. I'm not satisfied with the design myself, but I don't currently have a better idea for the implementation.

Related Issue

Closes #398

@seicke seicke marked this pull request as ready for review June 24, 2025 10:08
@seicke seicke requested a review from aaronzi June 24, 2025 10:08
Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation of Qualifiers. I will have a look at the visuals. But this is a good start. I will just change a few things.

I noticed a small bug where qualifiers are displayed twice. I tested this for example with the standardized SMTs. The multiplicity qualifiers are always there twice.

@aaronzi aaronzi requested a review from Copilot June 24, 2025 20:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new QualifierElement component to display qualifier details and integrates it into the SubmodelElementView.

  • Adds QualifierElement.vue for rendering kinds, semantic IDs, value types, and values of qualifiers.
  • Updates SubmodelElementView.vue to conditionally display the new qualifier component with dividers.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
aas-web-ui/src/components/UIComponents/QualifierElement.vue New component for rendering qualifier details
aas-web-ui/src/components/SubmodelElementView.vue Integrates QualifierElement and adds divider logic
Comments suppressed due to low confidence (1)

aas-web-ui/src/components/UIComponents/QualifierElement.vue:85

  • The qualifierArray prop defaults to an empty object, which may trigger runtime warnings. Change its type to Array (e.g., type: Array as PropType<Qualifier[]>) and default to an empty array (default: () => []).
            default: {} as any,

@seicke
Copy link
Member Author

seicke commented Jun 26, 2025

I noticed a small bug where qualifiers are displayed twice. I tested this for example with the standardized SMTs. The multiplicity qualifiers are always there twice.

Sorry, I missed deleting tmp code for testing purpose. It's fixed

@seicke
Copy link
Member Author

seicke commented Jun 26, 2025

I will have a look at the visuals. But this is a good start. I will just change a few things.

Thanks in advance!

@aaronzi aaronzi merged commit db32bab into eclipse-basyx:main Aug 8, 2025
2 checks passed
@seicke seicke deleted the qualifier branch August 10, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ticket] Visualization of Qualifiers
2 participants