Skip to content

Conversation

seicke
Copy link
Member

@seicke seicke commented Jun 24, 2025

Description of Changes

This PR adds a Submodel Viewer/Editor to view and edit Submodels independently from AAS.

  • Leveraging Submodel Registry

Related Issue

Closes #158

@seicke seicke changed the title Rename current SMViewer to AASSMViewer (Standalone) Submodel Viewer/Editor Jun 24, 2025
@aaronzi
Copy link
Member

aaronzi commented Jun 24, 2025

Looks already really cool 👍

Please keep in mind that you will have to handle pagination because the number of submodels could be rather big.

Are you also considering leveraging the Submodel Registry here?

@seicke
Copy link
Member Author

seicke commented Jun 26, 2025

Please keep in mind that you will have to handle pagination because the number of submodels could be rather big.

IMHO pagination seems to be still hard work to do (cause of the usage of the self-written VTreeview component)
And if you introducing pagination you would also like to have the auto scrolling to the selected SM/SME (cf. AASList component) ;)
Not sure if both can be realized in adequate time and effort with the VTreeview component.
Unfortunality the vuetify v-tree component is still in development.

Are you also considering leveraging the Submodel Registry here?

I think you are allude to the implementation of the AASList component. The AASList is a special case because it can be shown just with the data of the AAS registry.
If you leaverage the SM registry here, you have to do two reqests for all submodels, one to the registry following one request to the repo (for the SME data). Only the first first level of the tree (means just a list of submodels) can be displayed by using just requests to the SM registry. For the data of the whole treeview (with its SMEs) you always have to fetch the data from the SM repo. That's why I went straight to the SM repo first.
But you are right: It could be the case that there are SM descriptors in the SM registry including SM endpoints to different SM repos (not just the one specified in the gui settings). I will think how to implement this.

@aaronzi aaronzi marked this pull request as ready for review August 29, 2025 09:26
@aaronzi aaronzi merged commit b146475 into eclipse-basyx:main Aug 29, 2025
2 checks passed
@seicke seicke deleted the smviewer branch August 29, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow for single Submodels to be shown independently
2 participants