Align bookmarks, trace and optional parameters with TSP #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TSP specifies it as a map String to String and not as a map String to any type. Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
- Rename startTime to start - Rename endTime to end - Remove type Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Also, clarify default value of optional parameter ConfigurationParameterDescriptor.dataType Related to TSP fix: eclipse-cdt-cloud/trace-server-protocol#125 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
force-pushed
the
bugfixes4tsp
branch
from
9b44d4c to
99ec8dc
Compare
PatrickTasse
approved these changes
Sep 5, 2025
Contributor
Author
|
License check failure is unrelated and cause by an infrastructure issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR consists of multiple commits:
to any type.
Related to TSP fix: Required fields not always specified as required trace-server-protocol#125
How to test
Verify that implementation matches the TSP specification.
Follow-ups
N/A
Review checklist