remove ingress-nginx controller#2386
Open
kalinkostashki wants to merge 2 commits intoeclipse-ditto:masterfrom
Open
remove ingress-nginx controller#2386kalinkostashki wants to merge 2 commits intoeclipse-ditto:masterfrom
kalinkostashki wants to merge 2 commits intoeclipse-ditto:masterfrom
Conversation
- ingress-nginx is deprecated as of 31.03.2026 - controller should be something the user of the helm chart defines - removed all ingress-nginx specific annotations - removed nginx-ingress-auth.yaml and nginx-ingress.yaml -> those should now be defined externally - added a blog post for in order to explain the appraoch and reasons behind the decision + tested each scenario in the blogpost to make sure it works
Contributor
Author
|
@mladBlum you can take a look if you want since you would be interested in this if I remember correctly. |
Contributor
|
Looks good for me. As I see you solved also the hazle with ditto-ui access when removing the nginx stuff! That i was stuck on. I am glad that this is finally done. 👍 |
thjaeckle
approved these changes
Apr 8, 2026
Member
thjaeckle
left a comment
thjaeckle
left a comment
There was a problem hiding this comment.
Looks good, I suppose 😄
@kalinkostashki that means we would already introduce Helm chart version 4.0.0 together with Ditto release 3.9.0?
Might lead to confusion - we should document that somewhere that now Helm chart and Ditto appVersion are no longer aligned.
It was only a matter of time until that happens, so it's ok ..
Could you resolve the remaining merge conflicts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.