-
Notifications
You must be signed in to change notification settings - Fork 28
Add copy button for TD affordances (actions, properties, events) #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add copy button for TD affordances (actions, properties, events) #181
Conversation
✅ Deploy Preview for editdor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
egekorkan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- handleCopyXXX functions can be refactored to not copy paste the same thing
- You need to sign your commits and link your Eclipse account. Make sure to read https://github.com/eclipse/editdor/blob/master/CONTRIBUTING.md
- It would be muuuch better if the new affordance is just under the copied affordance. With longer TDs, it is very difficult to find it. Also, there is no visual confirmation that a new affordance is added.
Signed-off-by: Ayush <prakashayush414@gmail.com>
c92bfab to
d2879cf
Compare
Signed-off-by: Ayush <prakashayush414@gmail.com>
Changes include:
All commits are signed and Eclipse Contributor Agreement requirements are fulfilled. |
|
Hi @egekorkan |
|
@AyushPrakash414 much better, thank you! I think the visual confirmation should be a bit more pronounced. Even with the expectation how this should work, I had to double check (<1s for me). Maybe highlighting the new affordance would be nice, like an animation. Also, code formatting check is failing :) |
|
Hello @AyushPrakash414 thanks for your contribution. The initial feedback is:
A review will follow. Thanks! |
Fixes #57
This PR adds a copy button for Thing Description affordances (actions, properties, and events) in the visual editor.
Users can now duplicate similar affordances directly from the UI without switching to the JSON editor, improving usability and workflow efficiency.