Skip to content

Commit 9b121b3

Browse files
authored
Fix TENANT_CONFIGURATION > READ_GATEWAY_SECURITY_TOKEN imply (#2650)
Signed-off-by: Avgustin Marinov <Avgustin.Marinov@bosch.com>
1 parent 2c995b3 commit 9b121b3

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

hawkbit-security-core/src/main/java/org/eclipse/hawkbit/im/authentication/SpPermission.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public final class SpPermission {
140140
TENANT_CONFIGURATION + IMPLY_READ + TENANT_CONFIGURATION + "\n" +
141141
TENANT_CONFIGURATION + IMPLY_UPDATE + TENANT_CONFIGURATION + "\n" +
142142
TENANT_CONFIGURATION + IMPLY_DELETE + TENANT_CONFIGURATION + "\n" +
143-
TENANT_CONFIGURATION + IMPLY_CREATE + READ_GATEWAY_SECURITY_TOKEN + "\n";
143+
TENANT_CONFIGURATION + " > " + READ_GATEWAY_SECURITY_TOKEN + "\n";
144144

145145
// @formatter:on
146146
private static final SingletonSupplier<List<String>> ALL_AUTHORITIES = SingletonSupplier.of(() -> {

hawkbit-security-core/src/main/java/org/eclipse/hawkbit/im/authentication/SpRole.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ public final class SpRole {
3434

3535
private static final String IMPLIES = " > ";
3636
private static final String LINE_BREAK = "\n";
37+
38+
// @formatter:off
3739
public static final String TARGET_ADMIN_HIERARCHY =
3840
TARGET_ADMIN + IMPLIES + SpPermission.READ_TARGET + LINE_BREAK +
3941
TARGET_ADMIN + IMPLIES + SpPermission.READ_TARGET_SECURITY_TOKEN + LINE_BREAK +
@@ -44,12 +46,6 @@ public final class SpRole {
4446
TARGET_ADMIN + IMPLIES + SpPermission.UPDATE_TARGET_TYPE + LINE_BREAK +
4547
TARGET_ADMIN + IMPLIES + SpPermission.CREATE_PREFIX + SpPermission.TARGET_TYPE + LINE_BREAK +
4648
TARGET_ADMIN + IMPLIES + SpPermission.DELETE_TARGET_TYPE + LINE_BREAK;
47-
public static final String REPOSITORY_ADMIN_HIERARCHY =
48-
REPOSITORY_ADMIN + IMPLIES + SpPermission.READ_REPOSITORY + LINE_BREAK +
49-
REPOSITORY_ADMIN + IMPLIES + SpPermission.UPDATE_REPOSITORY + LINE_BREAK +
50-
REPOSITORY_ADMIN + IMPLIES + SpPermission.CREATE_REPOSITORY + LINE_BREAK +
51-
REPOSITORY_ADMIN + IMPLIES + SpPermission.DELETE_REPOSITORY + LINE_BREAK +
52-
REPOSITORY_ADMIN + IMPLIES + SpPermission.DOWNLOAD_REPOSITORY_ARTIFACT + LINE_BREAK;
5349
public static final String ROLLOUT_ADMIN_HIERARCHY =
5450
ROLLOUT_ADMIN + IMPLIES + SpPermission.READ_ROLLOUT + LINE_BREAK +
5551
ROLLOUT_ADMIN + IMPLIES + SpPermission.CREATE_ROLLOUT + LINE_BREAK +
@@ -65,11 +61,18 @@ public final class SpRole {
6561
public static final String SYSTEM_ROLE_HIERARCHY =
6662
SYSTEM_ROLE + IMPLIES + TENANT_ADMIN + LINE_BREAK +
6763
SYSTEM_ROLE + IMPLIES + SpPermission.SYSTEM_ADMIN + LINE_BREAK;
64+
public static final String REPOSITORY_ADMIN_HIERARCHY =
65+
REPOSITORY_ADMIN + IMPLIES + SpPermission.READ_REPOSITORY + LINE_BREAK +
66+
REPOSITORY_ADMIN + IMPLIES + SpPermission.UPDATE_REPOSITORY + LINE_BREAK +
67+
REPOSITORY_ADMIN + IMPLIES + SpPermission.CREATE_REPOSITORY + LINE_BREAK +
68+
REPOSITORY_ADMIN + IMPLIES + SpPermission.DELETE_REPOSITORY + LINE_BREAK +
69+
REPOSITORY_ADMIN + IMPLIES + SpPermission.DOWNLOAD_REPOSITORY_ARTIFACT + LINE_BREAK;
6870

6971
public static final String DEFAULT_ROLE_HIERARCHY =
7072
TARGET_ADMIN_HIERARCHY +
7173
REPOSITORY_ADMIN_HIERARCHY +
7274
ROLLOUT_ADMIN_HIERARCHY +
7375
TENANT_ADMIN_HIERARCHY +
7476
SYSTEM_ROLE_HIERARCHY;
77+
// @formatter:on
7578
}

0 commit comments

Comments
 (0)