-
Notifications
You must be signed in to change notification settings - Fork 92
[#865] Use core
and alloc
in Rust code
#1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[#865] Use core
and alloc
in Rust code
#1118
Conversation
7d06972
to
bf7bf1f
Compare
1327493
to
c3eff64
Compare
7d1e3f0
to
6ff1509
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
- Coverage 77.33% 77.27% -0.07%
==========================================
Files 362 364 +2
Lines 38954 39045 +91
Branches 346 346
==========================================
+ Hits 30125 30171 +46
- Misses 8185 8230 +45
Partials 644 644
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
02c47c3
to
4d16d9a
Compare
4f02b10
to
fd2b60c
Compare
} | ||
true => std::eprint!( | ||
"{}{:9} {} ", | ||
"{}{} {} ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this indentation so that logs with and without origin
are aligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, what do you think about moving the origin at the second position, after the log message? Maybe not in this PR but just in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elBoberido @elfenpiff I will leave it to you guys to decide. Could you create an issue if it's decided that we want to make the change.
core
and alloc
in Rust codecore
and alloc
in Rust code
core
and alloc
in Rust codecore
and alloc
in Rust code
fd2b60c
to
d05a2d4
Compare
…ceoryx2-bb-container
910c14b
to
47eb134
Compare
I added a wrapper for |
844c165
to
c5bfa36
Compare
c5bfa36
to
89a979f
Compare
Notes for Reviewer
Updates all crates to explicitly use components in
core
andalloc
.All crates were updated except for the following (to be done in a follow-up):
iceoryx2-cli
Additionally, the following changes were added to fix some quirks that were uncovered:
origin
is not providedorigin
is not provided|
character from log output whenorigin
is not providednull
logger default which does nothingPre-Review Checklist for the PR Author
Convert to draft
)SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates #865