-
Notifications
You must be signed in to change notification settings - Fork 99
[#1144] zero copy send unions #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1144] zero copy send unions #1145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for deriving ZeroCopySend on union types. Previously, the derive macro only supported structs and enums, and would generate a compile error for unions. Now unions are handled by generating compile-time checks that ensure all fields implement ZeroCopySend.
Key changes:
- Modified the
ZeroCopySendderive macro to handleData::Uniontypes - Added field-by-field validation for union types similar to struct handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| iceoryx2-bb/derive-macros/src/lib.rs | Replaces the default case that returned a compile error with explicit union handling that validates all fields implement ZeroCopySend |
| doc/release-notes/iceoryx2-unreleased.md | Documents the new union support feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
==========================================
- Coverage 77.90% 77.89% -0.01%
==========================================
Files 360 360
Lines 38788 38807 +19
Branches 807 807
==========================================
+ Hits 30216 30230 +14
- Misses 7933 7938 +5
Partials 639 639
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
fce4050 to
7bbcbf7
Compare
7bbcbf7 to
4807614
Compare
Notes for Reviewer
Pre-Review Checklist for the PR Author
Convert to draft)SPDX-License-Identifier: Apache-2.0 OR MITiox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)task-list-completed)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #1144